MLE-24763 Lint: Replacing double quotes #993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
First batch of lint-oriented refactors introducing single quotes and preferring const/let over var. Key changes focus on:
- Replacing most var declarations with const/let and converting double quotes to single quotes.
- Updating ESLint rules to enforce no-var and prefer-const (plus related stylistic consistency).
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/www-authenticate-patched/www-authenticate.js | Converted var to const/let and single-quoted strings. |
| lib/www-authenticate-patched/user-credentials.js | Updated variable declarations and string quotes. |
| lib/www-authenticate-patched/parsers.js | Replaced var with let/const and added semicolons. |
| lib/www-authenticate-patched/md5.js | Switched var to const. |
| lib/values.js | Replaced var with const/let across function logic. |
| lib/values-builder.js | Modernized declarations (var → const/let). |
| lib/transforms.js | Updated variable declarations and style. |
| lib/transactions.js | Modernized declarations and spacing. |
| lib/server-exec.js | Replaced var with const/let and updated string style. |
| lib/rows.js | Updated import style and variable declarations. |
| lib/rest-server-properties.js | Updated declarations to const. |
| lib/responder.js | Large-scale var → const/let refactor and property access tweaks. |
| lib/resources-exec.js | Modernized declarations; adjusted error strings. |
| lib/resources-config.js | Updated declarations and error handling strings. |
| lib/requester.js | Refactored auth/request helpers to const/let. |
| lib/query-builder.js | Extensive var → const/let updates across builder utilities. |
| lib/proxy-generator.js | Adjusted error messages (template literals to plain strings). |
| lib/plan-builder.js | Minor string style update. |
| lib/plan-builder-base.js | Converted template literal without interpolation to plain string. |
| lib/patch-builder.js | Modernized internal builder helper declarations. |
| lib/optional.js | Updated variable declaration to const. |
| lib/operation.js | Modernized operation helper internals. |
| lib/mlutil.js | Refactored utility helpers to const/let. |
| lib/mllog.js | Updated util import to const. |
| lib/marklogic.js | Modernized module imports and declarations. |
| lib/internal.js | Normalized imports (single quotes) and const usage. |
| lib/graphs.js | Partial modernization (some var remain, duplicate import). |
| lib/extlibs.js | Updated declarations and maintained logic. |
| lib/endpointDeclarationValidator.js | Converted JSON schema quotes/style. |
| lib/endpoint-proxy.js | Minor error message & style updates. |
| lib/documents.js | Large-scale modernization of declarations. |
| lib/basic-loader.js | Simplified error messages (removed unused template literals). |
| eslint.config.js | Added no-var and prefer-const enforcement rules. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
force-pushed
the
feature/24763-lint-2
branch
from
1523571 to
c8a9b1e
Compare
anu3990
reviewed
Oct 16, 2025
anu3990
requested changes
Oct 16, 2025
|
The tests failed again. Please check the following two - test-basic/endpoint-caller.js:84:35 and test-basic/service-caller.js:84:35 |
rjrudin
force-pushed
the
feature/24763-lint-2
branch
from
c8a9b1e to
f6e315f
Compare
|
Recent updates did not fix the test failures. Tests are still failing. |
anu3990
previously approved these changes
Oct 16, 2025
rjrudin
force-pushed
the
feature/24763-lint-2
branch
from
f6e315f to
9b3ab77
Compare
rjrudin
changed the title
|
Still getting 7 test failures when just replacing double quotes with single quotes, which makes no sense. Going to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just doing double quote replacement.